feat: vite + nitro support #51
Conversation
|
|
@pi0 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
You must have Developer access to commit code to Vercel Labs on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| rollupConfig: { | ||
| plugins: [workflowRollupPlugin()], | ||
| }, | ||
| } |
There was a problem hiding this comment.
The import of workflowRollupPlugin from 'workflow/rollup-plugin' is unused and should be removed. The rollupConfig that used it was removed on this commit since the Nitro module now handles the plugin injection automatically.
View Details
📝 Patch Details
diff --git a/workbench/nuxt/nuxt.config.ts b/workbench/nuxt/nuxt.config.ts
index ec2c3bc..023f0a9 100644
--- a/workbench/nuxt/nuxt.config.ts
+++ b/workbench/nuxt/nuxt.config.ts
@@ -1,5 +1,4 @@
import { defineNuxtConfig } from 'nuxt/config';
-import { workflowRollupPlugin } from 'workflow/rollup-plugin';
export default defineNuxtConfig({
compatibilityDate: 'latest',
Analysis
Unused import of workflowRollupPlugin in nuxt.config.ts
What fails: The import statement import { workflowRollupPlugin } from 'workflow/rollup-plugin'; on line 2 of workbench/nuxt/nuxt.config.ts is dead code - the imported symbol is never used anywhere in the file.
How to reproduce:
- Open
workbench/nuxt/nuxt.config.ts - Search for any reference to
workflowRollupPluginin the file - The symbol is only in the import statement and never referenced
What happens vs expected: The import exists but serves no purpose. The Nitro module (workflow/nitro) that is loaded via the modules: ['workflow/nitro'] configuration automatically injects the workflow rollup plugin via the Nitro rollup:before hook (see packages/nitro/src/index.ts lines 13-15), so importing it in the config file is redundant and unnecessary.
Expected behavior: The unused import should be removed to keep the configuration clean and avoid confusion.
2 participants
Moving to #172 due to CI issues